This patch series ports the ext4 direct IO paths to make use of the iomap infrastructure. The legacy buffer_head based direct IO paths have subsequently been removed as they're now no longer in use. The result of this change is that the direct IO implementation is much cleaner and keeps the code isolated from the buffer_head internals. In addition to this, a slight performance boost could be expected while using O_SYNC | O_DIRECT IO. The changes have been tested using xfstests in both DAX and non-DAX modes using various filesystem configurations i.e. 4k, dioread_nolock. Changes since v1: - The error handling code within ext4_dio_write_end_io() has been moved out into a common helper ext4_handle_failed_inode_extension(), which is now used by both DAX and direct IO paths. - Simplified the conditional statement in ext4_iomap_begin() that determined which flags needed to be passed to ext4_map_blocks(). - Split up patch 4/5 by taking out the hunk of code in ext4_iomap_begin() that determined the flag that should be assigned to iomap->type. - Introduced comments to snippets of code that are not immediately unambiguous and applied other minor cleanups based on the feedback that was received. In the previous patch series, there was a relatively lengthy discussion around the merging of unwritten extents. The buffer_head direct IO implementation made use of inode and end_io flags to track whether an unwritten extent is eligible to be merged, or not. We don't make use of these flags in the new direct IO iomap implementation, effectively making the extent merging checks that make use these flags redundant. However, it appears that even if additional merges and splits are performed, it isn't deemed problematic as such and that's due to the way that the filesystem now accommdates for unexpected extent splits. The only real concern is the potential wasted performance due to the unnecessary merge and split performed under specific workloads. The full discussion that goes through these details starts from here: https://www.spinics.net/lists/linux-ext4/msg67173.html. Thank you to all that took the time to review and provide constructive feedback for previous patch series, highly appreciated. Matthew Bobrowski (6): ext4: introduce direct IO read path using iomap infrastructure ext4: move inode extension/truncate code out from ext4_iomap_end() iomap: modify ->end_io() calling convention ext4: reorder map.m_flags checks in ext4_iomap_begin() ext4: introduce direct IO write path using iomap infrastructure ext4: cleanup legacy buffer_head direct IO code fs/ext4/ext4.h | 3 - fs/ext4/extents.c | 11 +- fs/ext4/file.c | 363 +++++++++++++++++++++++------ fs/ext4/inode.c | 516 +++++------------------------------------- fs/iomap/direct-io.c | 9 +- fs/xfs/xfs_file.c | 8 +- include/linux/iomap.h | 4 +- 7 files changed, 365 insertions(+), 549 deletions(-) -- 2.20.1
