On Thu, Sep 5, 2019 at 9:06 PM Jeff Layton <jlayton@xxxxxxxxxx> wrote: > > From: David Howells <dhowells@xxxxxxxxxx> > > Convert the ceph filesystem to the new internal mount API as the old > one will be obsoleted and removed. This allows greater flexibility in > communication of mount parameters between userspace, the VFS and the > filesystem. > > See Documentation/filesystems/mount_api.txt for more information. > > Signed-off-by: David Howells <dhowells@xxxxxxxxxx> > Reviewed-by: "Yan, Zheng" <zyan@xxxxxxxxxx> > cc: Ilya Dryomov <idryomov@xxxxxxxxx> > cc: Sage Weil <sage@xxxxxxxxxx> > cc: ceph-devel@xxxxxxxxxxxxxxx > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > --- > drivers/block/rbd.c | 341 ++++++++--------- > fs/ceph/cache.c | 10 +- > fs/ceph/cache.h | 5 +- > fs/ceph/super.c | 687 +++++++++++++++++------------------ > fs/ceph/super.h | 1 - > include/linux/ceph/libceph.h | 17 +- > net/ceph/ceph_common.c | 410 +++++++++------------ > 7 files changed, 715 insertions(+), 756 deletions(-) > > v2: fix several string parsing bugs in rbd_add_parse_args and rbd_parse_monolithic > prefix rbd log message with "rbd:" > drop unneeded #undef from ceph_debug.h > drop unrelated comment fixes in fs/fs_*.c > rebase onto current ceph/testing branch This is still broken. A simple "rbd map" works, but option parsing is busted: $ sudo rbd map -o ro testimg rbd: sysfs write failed In some cases useful info is found in syslog - try "dmesg | tail". rbd: map failed: (519) Unknown error 519 meaning errno = 519 from write()... On one of the attempts it crashed in kfree(), probably called from rbd_parse_monolithic(). Thanks, Ilya