On Tue, Sep 03, 2019 at 03:16:21PM -0700, Darrick J. Wong wrote: > The biggest problem with merging these patches (and while we're at it, > Goldwyn's patch adding a srcmap parameter to ->iomap_begin) for 5.4 is > that they'll break whatever Andreas and Damien have been preparing for > gfs2 and zonefs (respectively) based off the iomap-writeback work branch > that I created off of 5.3-rc2 a month ago. Does Andreas have changes pending that actually pass an end_io call back to gfs2? So far it just passed NULL so nothing should change. If my memory serves me correctly zonefs uses ->end_io, but then again Damien is asking you to queue it up with the iomap tree, so doing that trivial rebase shouldn't be an issue.