As Christoph suggested [1], update them all. [1] https://lore.kernel.org/r/20190829102426.GE20598@xxxxxxxxxxxxx/ Reported-by: Christoph Hellwig <hch@xxxxxxxxxxxxx> Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx> --- fs/erofs/inode.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c index f6dfd0271261..a42f5fc14df9 100644 --- a/fs/erofs/inode.c +++ b/fs/erofs/inode.c @@ -147,7 +147,7 @@ static int fill_inline_data(struct inode *inode, void *data, if (vi->datalayout != EROFS_INODE_FLAT_INLINE) return 0; - /* fast symlink (following ext4) */ + /* fast symlink */ if (S_ISLNK(inode->i_mode) && inode->i_size < PAGE_SIZE) { char *lnk = erofs_kmalloc(sbi, inode->i_size + 1, GFP_KERNEL); @@ -156,7 +156,7 @@ static int fill_inline_data(struct inode *inode, void *data, m_pofs += vi->inode_isize + vi->xattr_isize; - /* inline symlink data shouldn't across page boundary as well */ + /* inline symlink data shouldn't cross page boundary as well */ if (m_pofs + inode->i_size > PAGE_SIZE) { kfree(lnk); errln("inline data cross block boundary @ nid %llu", @@ -165,7 +165,6 @@ static int fill_inline_data(struct inode *inode, void *data, return -EFSCORRUPTED; } - /* get in-page inline data */ memcpy(lnk, data + m_pofs, inode->i_size); lnk[inode->i_size] = '\0'; -- 2.17.1
