Re: [PATCH] fanotify: remove always false comparison in copy_fid_to_user

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 03-09-19 04:28:21, Matthew Wilcox wrote:
> On Tue, Sep 03, 2019 at 09:54:14AM +0800, zhengbin wrote:
> > Fixes gcc warning:
> > 
> > fs/notify/fanotify/fanotify_user.c:252:19: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> > 
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: zhengbin <zhengbin13@xxxxxxxxxx>
> 
> When fixing bugs like this, please do a git log -p and cc the person
> responsible for introducing the code you're fixing.  Also add a Fixes:
> line.

Generally I agree although in this particular case it is just a cosmetic
fix so I don't find that very important. 

> Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Thanks for review!

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux