On 18:43 02/09, Christoph Hellwig wrote: > On Sun, Sep 01, 2019 at 03:08:21PM -0500, Goldwyn Rodrigues wrote: > > This is an effort to use iomap for btrfs. This would keep most > > responsibility of page handling during writes in iomap code, hence > > code reduction. For CoW support, changes are needed in iomap code > > to make sure we perform a copy before the write. > > This is in line with the discussion we had during adding dax support in > > btrfs. > > This looks pretty good modulo a few comments. > > Can you please convert the XFS code to use your two iomaps for COW > approach as well to validate it? > > Also the iomap_file_dirty helper would really benefit from using the > two iomaps, any chance you could look into improving it to use your > new infrastructure? Yes. However, I haven't looked at much of XFS code, but from the initial looks of it, it is simple to read. -- Goldwyn
