Hi Christoph, On Mon, Sep 02, 2019 at 08:06:40AM -0700, Christoph Hellwig wrote: > On Mon, Sep 02, 2019 at 04:20:37PM +0200, David Sterba wrote: > > Oh right, I think the reasons are historical and that we can remove the > > options nowadays. From the compatibility POV this should be safe, with > > ACLs compiled out, no tool would use them, and no harm done when the > > code is present but not used. > > > > There were some efforts by embedded guys to make parts of kernel more > > configurable to allow removing subsystems to reduce the final image > > size. In this case I don't think it would make any noticeable > > difference, eg. the size of fs/btrfs/acl.o on release config is 1.6KiB, > > while the whole module is over 1.3MiB. > > Given that the erofs folks have an actual use case for it I think > it is fine to keep the options, I just wanted to ensure this wasn't > copy and pasted for no good reason. Note that for XFS we don't have > an option for xattrs, as those are integral to a lot of file system > features. WE have an ACL option mostly for historic reasons. Add a word, xattr is necessary for Android, but ACL is not. I'm fine with killing these two, but EROFS can be used in more wider embedded scenerios (other than Android), I have no idea xattrs is useful for those embedded devices... Thanks, Gao Xiang
