On 2019/8/29 23:43, Dan Carpenter wrote: >> p.s. There are 2947 (un)likely places in fs/ directory. > > I was complaining about you adding new pointless ones, not existing > ones. The likely/unlikely annotations are supposed to be functional and > not decorative. I explained this very clearly. > > Probably most of the annotations in fs/ are wrong but they are also > harmless except for the slight messiness. However there are definitely > some which are important so removing them all isn't a good idea. Hi Dan, Could you please pick up one positive example using likely and unlikely correctly? so we can follow the example, rather than removing them all blindly. Thanks, > >> If you like, I will delete them all. > > But for erofs, I don't think that any of the likely/unlikely calls have > been thought about so I'm fine with removing all of them in one go. > > regards, > dan carpenter > > . >
