On Tue, 27 Aug 2019 10:34:57 +0200 Cornelia Huck <cohuck@xxxxxxxxxx> wrote: > On Wed, 21 Aug 2019 13:57:05 -0400 > Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > +static bool vp_get_shm_region(struct virtio_device *vdev, > > + struct virtio_shm_region *region, u8 id) > > +{ > > + struct virtio_pci_device *vp_dev = to_vp_device(vdev); > > This whole function looks like it is indented incorrectly. Hmpf, it looks like my mail client is squashing tabs, so the indentation looks off here, but is probably fine :) It's the function above that seems to have a mix of spaces and tabs. > > > + struct pci_dev *pci_dev = vp_dev->pci_dev; > > + u8 bar; > > + u64 offset, len; > > + phys_addr_t phys_addr; > > + size_t bar_len; > > + char *bar_name; > > + int ret;