On Sat, May 17, 2008 at 2:11 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >> Attached is a patch which adds various options to cifs_show_options >> (displayed when you cat /proc/mounts with a cifs mount). > > Thanks. > >> I limited >> the new ones to values that are associated with the mount > > Why? cifs (and also nfs apparently) have some mount options which are stored per-mount and some which affect all connections to the same server from this client (ie affect the whole smb session, and are stored in a different structure). I thought it would be confusing to list properties shared by more than one mount in cifs_show_options (most of these are visible in /proc/fs/cifs/DebugData for debugging purposes if needed) - although I made exceptions for the userid and domain and for the per-tree-connection property "seal" since users are likely to be more interested in these. >> Eventually (as you suggested) cifs's parse_mount_options also needs to >> be rewritten to use the match_token API but that would be a big enough >> change that I would prefer that changing parse_mount_options wait >> until 2.6.27 > > Yes, there's no hurry with that. It's just that it would be easier to > keep the showing in sync with the parsing if the parsing wasn't so > unruly. > > Miklos > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
