> > From: Miklos Szeredi <mszeredi@xxxxxxx>
> >
> > The FAT_IOCTL_SET_ATTRIBUTES ioctl() calls notify_change() to change
> > the file mode before changing the inode attributes. Replace with
> > explicit calls to security_inode_setattr(), fat_setattr() and
> > fsnotify_change().
> >
> > This is equivalent to the original. The reason it is needed, is that
> > later in the series we move the immutable check into notify_change().
> > That would break the FAT_IOCTL_SET_ATTRIBUTES ioctl, as it needs to
> > perform the mode change regardless of the immutability of the file.
> >
> > Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
> > CC: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
>
> Don't we need to add EXPORT_SYMBOL(security_inode_setattr)?
Yes we do, thanks for noticing. Committed the below patch to the
vfs-cleanups tree.
> Otherwise,
> looks good to me.
>
> Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
Thanks.
Miklos
----
Subject: fat: don't call notify_change fix
From: Miklos Szeredi <mszeredi@xxxxxxx>
ERROR: "security_inode_setattr" [fs/fat/fat.ko] undefined!
Fix error if fat is built as a module. Thanks to OGAWA Hirofumi for
noticing.
Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
CC: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
---
security/security.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/security/security.c
===================================================================
--- linux-2.6.orig/security/security.c 2008-05-14 12:49:42.000000000 +0200
+++ linux-2.6/security/security.c 2008-05-17 08:46:52.000000000 +0200
@@ -476,6 +476,7 @@ int security_inode_setattr(struct dentry
return 0;
return security_ops->inode_setattr(dentry, attr);
}
+EXPORT_SYMBOL_GPL(security_inode_setattr);
int security_inode_getattr(struct vfsmount *mnt, struct dentry *dentry)
{
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
