On Fri, Aug 16, 2019 at 11:01:13AM +0200, Hans de Goede wrote: > TL;DR: I believe that the current approach which is 3. from above is > good enough and I like that it is very KISS. We can always switch to > 1. or 2. (or add 1. and 2. and make it configurable) later if this shows > to be necessary. > > Can you please let me know if option 3. / the KISS method is ok with you, > or if you would prefer me to add code to do 1. or 2? I'm not sure I actually care. Reading through the code just made me realizie that no sane person should use this. Obviously there are plenty of insane people, otherwise virtualbox wouldn't be around anymore anyway, and they apparently lived with much worse bugs before. What I do care about is that someone actually thought about these issues, which you very much did (probably unlike the original authors). Maybe explaining these choice in code comments in addition to the email would help, though.
