On Wed, Aug 14, 2019 at 02:11:08PM +0000, Mainz, Roland wrote: > > > > > -----Original Message----- > > From: linux-mtd [mailto:linux-mtd-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of > > Sascha Hauer > > Sent: Wednesday, August 14, 2019 2:19 PM > > To: linux-fsdevel@xxxxxxxxxxxxxxx > > Cc: Richard Weinberger <richard@xxxxxx>; Sascha Hauer > > <s.hauer@xxxxxxxxxxxxxx>; linux-mtd@xxxxxxxxxxxxxxxxxxx; > > kernel@xxxxxxxxxxxxxx; Jan Kara <jack@xxxxxxxx> > > Subject: [PATCH 07/11] ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls > > > > The FS_IOC_FS[SG]ETXATTR ioctls are an alternative to FS_IOC_[GS]ETFLAGS > > with additional features. This patch adds support for these ioctls. > > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > --- > > fs/ubifs/ioctl.c | 89 > > +++++++++++++++++++++++++++++++++++++++++++++--- > > 1 file changed, 84 insertions(+), 5 deletions(-) > > > > diff --git a/fs/ubifs/ioctl.c b/fs/ubifs/ioctl.c index > > b9c4a51bceea..121aa1003e24 100644 > > --- a/fs/ubifs/ioctl.c > > +++ b/fs/ubifs/ioctl.c > > @@ -95,9 +95,39 @@ static int ubifs2ioctl(int ubifs_flags) > > return ioctl_flags; > > } > > > > -static int setflags(struct file *file, int flags) > > +/* Transfer xflags flags to internal */ static inline unsigned long > > +ubifs_xflags_to_iflags(__u32 xflags) > > { > > - int oldflags, err, release; > > + unsigned long iflags = 0; > > + > > + if (xflags & FS_XFLAG_SYNC) > > + iflags |= UBIFS_APPEND_FL; > > Erm... what does |FS_XFLAG_SYNC| have to do with |*APPEND| ? Is this a typo ? Hm, some copy-paste accident probably. That's rubbish of course. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
