On Mon, Aug 12, 2019 at 10:18:32AM -0700, Christoph Hellwig wrote: > please add linux-xfs to the cc list for the whole series. Besides > touching xfs itself it is also mentioned in MAINTAINERS for the iomap > code. Firstly, thank you for the review, highly appreciated! Secondly, not a problem, will do. > On Mon, Aug 12, 2019 at 10:53:11PM +1000, Matthew Bobrowski wrote: > > - if (size <= 0) > > - return size; > > + if (error || !size) > > + return error ? error : size; > > This should be: > > if (error) > return error; > if (!size) > return 0; OK. > > if (flags & IOMAP_DIO_COW) { > > - error = xfs_reflink_end_cow(ip, offset, size); > > - if (error) > > + ret = xfs_reflink_end_cow(ip, offset, size); > > + if (ret) > > I think we can just keep reusing error here. Ah yes, that will work. > > +typedef int (iomap_dio_end_io_t)(struct kiocb *iocb, ssize_t size, > > + ssize_t error, unsigned int flags); > > error should be an int and not a ssize_t. Updated. --M