On Mon, Aug 12, 2019 at 10:57 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > Quoting Brendan Higgins (2019-08-12 22:06:04) > > On Mon, Aug 12, 2019 at 9:24 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > > > > > Quoting Brendan Higgins (2019-08-12 11:24:13) > > > > + > > > > +static int kunit_try_catch_test_init(struct kunit *test) > > > > +{ > > > > + struct kunit_try_catch_test_context *ctx; > > > > + > > > > + ctx = kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); > > > > > > Can this fail? Should return -ENOMEM in that case? > > > > Yes, I should do that. > > Looks like it's asserted to not be an error. If it's pushed into the API > then there's nothing to do here, and you can have my reviewed-by on this > patch. > > Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxx> Cool, thanks!