On Sat 10-08-19 11:01:16, Paul Moore wrote: > On August 10, 2019 6:05:27 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > >>>> Other than Casey's comments, and ACK, I'm not seeing much commentary > >>>> on this patch so FS and LSM folks consider this your last chance - if > >>>> I don't hear any objections by the end of this week I'll plan on > >>>> merging this into selinux/next next week. > >>> > >>> Please consider it is summer time so people may be on vacation like I was... > >> > >> This is one of the reasons why I was speaking to the mailing list and > >> not a particular individual :) > > > > Jan is fsnotify maintainer, so I think you should wait for an explicit ACK > > from Jan or just merge the hook definition and ask Jan to merge to > > fsnotify security hooks. > > Aaron posted his first patch a month ago in the beginning of July and I > don't recall seeing any comments from Jan on any of the patch revisions. > I would feel much better with an ACK/Reviewed-by from Jan, or you - which > is why I sent that email - but I'm not going to wait forever and I'd like > to get this into -next soon so we can get some testing. Yeah, sorry for the delays. I'm aware of the patch but I was also on vacation and pretty busy at work so Amir always beat me in commenting on the patch and I didn't have much to add. Once Aaron fixes the latest comments from Amir, I'll give the patch the final look and give my ack. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
