Hi Gao, On Wed, 7 Aug 2019 01:02:58 +0800 Gao Xiang <hsiangkao@xxxxxxx> wrote: > > On Wed, Aug 07, 2019 at 01:34:23AM +1000, Stephen Rothwell wrote: > > > > One small suggestion: just remove the file names from the comments at > > the top of the files rather than change them to reflect that they have > > moved. We can usually tell the name of a file by its name :-) > > Thanks for your reply :) > > For this part, EROFS initially followed what ext4, f2fs, even fsverity do, > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ext4/namei.c > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/f2fs/namei.c > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/tree/fs/verity/verify.c?h=fsverity > > I think I can remove these filenames as you suggested in the next version. > I thought these are some common practice and there is no obvious right or > wrong of this kind of stuffs. Fair enough. -- Cheers, Stephen Rothwell
Attachment:
pgp3ojjrvGvzp.pgp
Description: OpenPGP digital signature
