Hi Andreas, any chance you could trim your quote to the relevant parts? On Sun, Aug 04, 2019 at 04:59:25PM +0200, Andreas Gruenbacher wrote: > > + /* > > + * File systems can perform actions at submit time and/or override > > + * the end_io handler here for complex operations like copy on write > > + * extent manipulation or unwritten extent conversions. > > + */ > > + if (wpc->ops->submit_ioend) > > + error = wpc->ops->submit_ioend(ioend, error); > > I think we only want to call submit_ioend here if error isn't set already. No, we need to call it even with an error so that the file system can override the bi_end_io handler, which bio_endio ends up calling even for the error case. Maybe the comment above could use an update to make that more clear.
