On Tue, Jul 30, 2019 at 6:31 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> On Mon, Jul 29, 2019 at 06:49:23PM -0700, Deepa Dinamani wrote:
> > Also update the gran since pstore has microsecond granularity.
>
> So, I'm fine with this, but technically the granularity depends on the
> backend storage... many have no actual time keeping, though. My point is,
> pstore's timestamps are really mostly a lie, but the most common backend
> (ramoops) is seconds-granularity.
>
> So, I'm fine with this, but it's a lie but it's a lie that doesn't
> matter, so ...
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> I'm open to suggestions to improve it...
If we don't care about using sub-second granularity, then setting it
to one second unconditionally here will make it always use that and
report it correctly.
Arnd
