Hi, On 16/07/2019 20:08, Jaskaran Singh Khurana wrote: >>> Could you please provide feedback on this v6 version. >> >> Hi, >> >> I am ok with the v6 patch; I think Mike will return to it in 5.4 reviews. >> > > Thanks for the help and also for reviewing this patch. Could you please > add Reviewed-by/Tested-by tag to the patch. ok, you can add Tested-and-Reviewed-by: Milan Broz <gmazyland@xxxxxxxxx> or just use the version on my git, I already updated few lines because of recent kernel changes, mainly the revert of keyring changes, tested patch is here https://git.kernel.org/pub/scm/linux/kernel/git/mbroz/linux.git/commit/?h=dm-cryptsetup&id=266f7c9c74b23e4cb2e67ceb813dd707061c1641 ... > The steps and workflow is correct. I will send the cryptsetup changes for > review. ok, I'll probably try to use our existing userspace libcryptsetup API to avoid introducing new calls, but that is not important for now - the kernel bits must be in the mainline kernel first. Thanks, Milan
