Looks good. Reviewed-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx> -- Best regards, Pavel Shilovsky вт, 16 июл. 2019 г. в 18:02, ronnie sahlberg <ronniesahlberg@xxxxxxxxx>: > > Nice. > > Reviewed-by me > > On Wed, Jul 17, 2019 at 10:51 AM Steve French <smfrench@xxxxxxxxx> wrote: > > > > Pavel spotted the problem - fixed and reattached updated patch > > > > > > On Tue, Jul 16, 2019 at 7:02 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > > > The attached patch adds support for flock support similar to AFS, NFS etc. > > > > > > Although the patch did seem to work in my experiments with flock, I did notice > > > that xfstest generic/504 fails because /proc/locks is not updated by cifs.ko > > > after a successful lock. Any idea which helper function does that? > > > > > > > > > -- > > > Thanks, > > > > > > Steve > > > > > > > > -- > > Thanks, > > > > Steve