On Thu 11-07-19 10:56:52, Steve Magnani wrote: > On 7/11/19 10:04 AM, Jan Kara wrote: > > Thanks for the patches! I've added them to my tree and somewhat simplified > > the logic since we don't really care about nsr 2 vs 3 or whether we > > actually saw BEA or not. Everything seems to work fine for me but I'd > > appreciate if you could doublecheck - the result is pushed out to > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_next > > > Tested-by: Steven J. Magnani <steve@xxxxxxxxxxxxxxx> > > The rework is more permissive than what you had suggested initially > (conditioning acceptance of a noncompliant NSR on a preceding BEA). > I had also tried to code the original so that a malformed 2048-byte > interval VRS would not be accepted. But the simplifications do make > the code easier to follow... Yeah, it's simpler to follow and we do this check just to see whether this may be a valid UDF media before doing more expensive probing. So I don't think that the code being more permissive matters. Thanks for testing! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
