On Wed 10-07-19 09:47:12, Dave Chinner wrote: > On Mon, Jul 08, 2019 at 03:31:14PM +0200, Jan Kara wrote: > > I'd be really careful with nesting range locks. You can have nasty > > situations like: > > > > Thread 1 Thread 2 > > read_lock(0,1000) > > write_lock(500,1500) -> blocks due to read lock > > read_lock(1001,1500) -> blocks due to write lock (or you have to break > > fairness and then deal with starvation issues). > > > > So once you allow nesting of range locks, you have to very carefully define > > what is and what is not allowed. > > Yes. I do understand the problem with rwsem read nesting and how > that can translate to reange locks. > > That's why my range locks don't even try to block on other pending > waiters. The case where read nesting vs write might occur like above > is something like copy_file_range() vs truncate, but otherwise for > IO locks we simply don't have arbitrarily deep nesting of range > locks. > > i.e. for your example my range lock would result in: > > Thread 1 Thread 2 > read_lock(0,1000) > write_lock(500,1500) > <finds conflicting read lock> > <marks read lock as having a write waiter> > <parks on range lock wait list> > <...> > read_lock_nested(1001,1500) > <no overlapping range in tree> > <gets nested range lock> > > <....> > read_unlock(1001,1500) <stays blocked because nothing is waiting > on (1001,1500) so no wakeup> > <....> > read_unlock(0,1000) > <sees write waiter flag, runs wakeup> > <gets woken> > <retries write lock> > <write lock gained> > > IOWs, I'm not trying to complicate the range lock implementation > with complex stuff like waiter fairness or anti-starvation semantics > at this point in time. Waiters simply don't impact whether a new lock > can be gained or not, and hence the limitations of rwsem semantics > don't apply. > > If such functionality is necessary (and I suspect it will be to > prevent AIO from delaying truncate and fallocate-like operations > indefinitely) then I'll add a "barrier" lock type (e.g. > range_lock_write_barrier()) that will block new range lock attempts > across it's span. > > However, because this can cause deadlocks like the above, a barrier > lock will not block new *_lock_nested() or *_trylock() calls, hence > allowing runs of nested range locking to complete and drain without > deadlocking on a conflicting barrier range. And that still can't be > modelled by existing rwsem semantics.... Clever :). Thanks for explanation. > > That's why in my range lock implementation > > ages back I've decided to treat range lock as a rwsem for deadlock > > verification purposes. > > IMO, treating a range lock as a rwsem for deadlock purposes defeats > the purpose of adding range locks in the first place. The > concurrency models are completely different, and some of the > limitations on rwsems are a result of implementation choices rather > than limitations of a rwsem construct. Well, even a range lock that cannot nest allows concurrent non-overlapping read and write to the same file which rwsem doesn't allow. But I agree that your nesting variant offers more (but also at the cost of higher complexity of the lock semantics). > In reality I couldn't care less about what lockdep can or can't > verify. I've always said lockdep is a crutch for people who don't > understand locks and the concurrency model of the code they > maintain. That obviously extends to the fact that lockdep > verification limitations should not limit what we allow new locking > primitives to do. I didn't say we have to constrain new locking primitives to what lockdep can support. It is just a locking correctness verification tool so naturally lockdep should be taught to what it needs to know about any locking scheme we come up with. And sometimes it is just too much effort which is why e.g. page lock still doesn't have lockdep coverage. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
