On Mon, Jul 08, 2019 at 11:46:52AM -0700, Christoph Hellwig wrote: > On Mon, Jul 01, 2019 at 10:01:59AM -0700, Darrick J. Wong wrote: > > Hi all, > > > > This series breaks up fs/iomap.c by grouping the functions by major > > functional area (swapfiles, fiemap, seek hole/data, directio, buffered > > writes, buffered reads, page management, and page migration) in separate > > source code files under fs/iomap/. No functional changes have been > > made. > > > > Note that this is not the final format of the patches, because I intend > > to pick a point towards the end of the merge window (after everyone > > else's merges have landed), rebase this series atop that, and push it > > back to Linus. The RFC is posted so that everyone can provide feedback > > on the grouping strategy, not line-specific code movements. > > > > This has been lightly tested with fstests. Enjoy! > > Comments and questions are, as always, welcome. > > Do you have a branch somewhere for the layout? I sent it out to for-next to see what it would collide with: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git/log/?h=iomap-5.3-merge Though I'll probably rebase it after the mm and block merges (which might have already happened). > To me it seems to be a little too fine grained and creates tons of tiny > files, which make hacking the code painful. It's nine files and now code is grouped by functional area which makes it easier to keep track of which functions go with the publicly exposed iomap apis. I don't think we're going to more than a half dozen more files ever. --D
