On 03/07/2019 20:21, Jan Kara wrote: > On Wed 03-07-19 04:04:57, Boaz Harrosh wrote: >> On 19/06/2019 11:21, Jan Kara wrote: >> <> <> >> Hi Jan >> >> Funny I'm sitting on the same patch since LSF last. I need it too for other >> reasons. I have not seen, have you pushed your patch yet? >> (Is based on old v4.20) > > Your patch is wrong due to lock ordering. You should not call vfs_fadvise() > under mmap_sem. So we need to do a similar dance like madvise_remove(). I > have to get to writing at least XFS fix so that the madvise change gets > used and post the madvise patch with it... Sorry it takes me so long. > > Honza Ha Sorry I was not aware of this. Lockdep did not catch it on my setup because my setup does not have any locking conflicts with mmap_sem on the WILL_NEED path. But surly you are right because the all effort is to fix the locking problems. I will also try in a day or two to do as you suggest, and look at madvise_remove() once I have a bit of time. Who ever gets to be less busy ... Thank you for your help Boaz
