On 17:21 21/06, Darrick J. Wong wrote: > On Fri, Jun 21, 2019 at 02:28:25PM -0500, Goldwyn Rodrigues wrote: > > From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> > > > > btrfs uses page->private as well to store extent_buffer. Make > > the check stricter to make sure we are using page->private for iop by > > comparing iblocksize < PAGE_SIZE. > > > > Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> > > /me wonders what will happen when btrfs decides to support blocksize != > pagesize... will we have to add a pointer to struct iomap_page so that > btrfs can continue to associate an extent_buffer with a page? > Yes, I did not think about that. It would be nasty to put wrappers to get to the right pointer. -- Goldwyn