On Tue, Jun 25, 2019 at 12:15:15PM +0200, Christoph Hellwig wrote: > On Tue, Jun 25, 2019 at 09:49:21AM +1000, Dave Chinner wrote: > > > +#undef TRACE_SYSTEM > > > +#define TRACE_SYSTEM iomap > > > > Can you add a comment somewhere here that says these tracepoints are > > volatile and we reserve the right to change them at any time so they > > don't form any sort of persistent UAPI that we have to maintain? > > Sure. Note that we don't have any such comment in xfs either.. I think we ought to add a comment to both of the tracepoint header files in xfs then... --D