xfs will need to be updated to fill in the additional iomap for the COW case. Has this series been tested on xfs? I can't say I'm a huge fan of this two iomaps in one method call approach. I always though two separate iomap iterations would be nicer, but compared to that even the older hack with just the additional src_addr seems a little better.