> > From: Miklos Szeredi <mszeredi@xxxxxxx> > > > > The FAT_IOCTL_SET_ATTRIBUTES ioctl() calls notify_change() to change > > the file mode before changing the inode attributes. Replace with > > explicit call to fat_setattr(). > > > > This is equivalent, except that security_inode_setattr() is not called > > before fat_setattr(). I think this is not needed, since the mode > > change is just a side effect of the attribute change. > > Actually I think we want the security_inode_setattr. This is an > implicit chmode when switching the ATTR_RO flag on and off and we should > have the full security check for it. Yes, I'm a bit uncertain about this. It's a user action that triggers the mode change. On the other hand it's just a side effect of the ioctl. I can re-add the security check just to be on the safe side, but probably nobody cares. Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
