On Tue, May 06, 2008 at 11:13:31AM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi <mszeredi@xxxxxxx> > > Reiserfs calls notify_change() on it's private extended attribute > files to resize and change ownership of these files. Replace with > reiserfs_setattr(). > > This is equivalent, except that: > > - i_alloc_sem locking is not performed around reiserfs_setattr() when > the size is changed > - security_inode_setattr() is not called before reiserfs_setattr() > - fsnotify_change() is not called after reiserfs_setattr() > > None of the above is necessary, since the files are private to > reiserfs and inaccessible from userspace. > > Also remove setting of ctime on the xattr files. I think splitting out the ATTR_SIZE case of reiserfs_setattr into a separate helper would be better. That would a) avoid the useless c and mtime updates on the attribue inode and b) clean up reiserfs_setattr a little bit. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
