On Mon, May 05 2008, Miklos Szeredi wrote: > From: Miklos Szeredi <mszeredi@xxxxxxx> > > generic_file_splice_write() duplicates remove_suid() just because it > doesn't hold i_mutex. But it grabs i_mutex inside splice_from_pipe() > anyway, so this is rather pointless. > > Move locking to generic_file_splice_write() and call remove_suid() and > __splice_from_pipe() instead. > > Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx> > CC: Jens Axboe <jens.axboe@xxxxxxxxxx> Looks good to me, applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html