Re: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: Re: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 7 Jun 2019 15:07:28 -0700
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Deepa Dinamani <deepa.kernel@xxxxxxxxx>, Linux List Kernel Mailing <linux-kernel@xxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Davidlohr Bueso <dbueso@xxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Davidlohr Bueso <dave@xxxxxxxxxxxx>, Eric Wong <e@xxxxxxxxx>, Jason Baron <jbaron@xxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, linux-aio@xxxxxxxxx, omar.kilani@xxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, David Laight <David.Laight@xxxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>
In-reply-to: <87ef45axa4.fsf_-_@xmission.com>

On Fri, Jun 7, 2019 at 2:41 PM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> The sigsuspend system call overrides the signal mask just
> like all of the other users of set_user_sigmask, so convert
> it to use the same helpers.

Me likey.

Whole series looks good to me, but that's just from looking at the
patches. Maybe testing shows problems..

              Linus

References:
- [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()
  - From: Deepa Dinamani
- pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask())
  - From: Oleg Nesterov
- [PATCH] signal: remove the wrong signal_pending() check in restore_user_sigmask()
  - From: Oleg Nesterov
- [PATCH 0/2] select: simplify the usage of restore_saved_sigmask_unless()
  - From: Oleg Nesterov
- [RFC PATCH 0/5]: Removing saved_sigmask
  - From: Eric W. Biederman
- [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask
  - From: Eric W. Biederman

Prev by Date: [RFC PATCH 5/5] signal: Remove the unnecessary restore_sigmask flag
Next by Date: Re: [PATCH v4 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()
Previous by thread: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask
Next by thread: Re: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]