On Mon, May 05, 2008 at 11:54:47AM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi <mszeredi@xxxxxxx> > > sysfs_chmod_file() calls notify_change() to change the permission bits > on a sysfs file. Replace with explicit call to sysfs_setattr() and > fsnotify_change(). > > This is equivalent, except that security_inode_setattr() is not > called. This function is called by drivers, so the security checks do > not make any sense. Are you sure? As a user, you can chmod the sysfs file and it will stick, I thought that is what this function was accomplishing. You will want to call the security checks in those cases, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
