Re: [patch 13/15] vfs: utimes cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 05, 2008 at 02:39:47PM +0200, Miklos Szeredi wrote:
> > checks into it aswell, even if that means a little flag telling if
> > file->f_mode should be checked or vfs_permission().
> 
> How would that be better?  There's zero commonality between the two
> kinds of permission checks (other than utimes_need_permission()).

it looks very similar.  but actually given that the next patch removes
the IS_IMMUTABLE check in the fd case it isn't anymore.  You're probably
right that it doesn't make sense to move it to the common one.

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux