On Mon 27-05-19 16:26:03, Amir Goldstein wrote: > On Mon, May 27, 2019 at 1:54 PM Jan Kara <jack@xxxxxxx> wrote: > > > > On Sun 26-05-19 17:34:04, Amir Goldstein wrote: > > > This will allow generating fsnotify delete events after the > > > fsnotify_nameremove() hook is removed from d_delete(). > > > > > > Cc: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > > Cc: Anna Schumaker <anna.schumaker@xxxxxxxxxx> > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > > --- > > > net/sunrpc/rpc_pipe.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > Hum, I don't think all __rpc_depopulate() calls are guarded by i_rwsem > > (e.g. those in rpc_gssd_dummy_populate()). Why aren't we using > > rpc_depopulate() in those cases? Trond, Anna? > > > > Do we care? For fsnotify hook, we should only care that > d_parent/d_name are stable. > They are stable because rpc_pipefs has no rename. Yeah, good point. Probably we don't. I was just wondering... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
