patch #15 moves include/linux/coda_psdev.h to fs/coda/coda_psdev.h and patch #16 removes include/uapi/linux/coda_psdev.h. Maybe #15 wasn't applied yet? Jan On May 17, 2019 7:29:51 PM EDT, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: >On Fri, 17 May 2019 14:36:54 -0400 Jan Harkes <jaharkes@xxxxxxxxxx> >wrote: > >> Nothing is left in this header that is used by userspace. >> >> fs/coda/coda_psdev.h | 5 ++++- >> include/uapi/linux/coda_psdev.h | 10 ---------- > >Confused. There is no fs/coda/coda_psdev.h. I did this. It compiles >OK... > > >From: Jan Harkes <jaharkes@xxxxxxxxxx> >Subject: coda: remove uapi/linux/coda_psdev.h > >Nothing is left in this header that is used by userspace. > >Link: >http://lkml.kernel.org/r/bb11378cef94739f2cf89425dd6d302a52c64480.1558117389.git.jaharkes@xxxxxxxxxx >Signed-off-by: Jan Harkes <jaharkes@xxxxxxxxxx> >Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >--- > > include/linux/coda_psdev.h | 5 ++++- > include/uapi/linux/coda_psdev.h | 10 ---------- > 2 files changed, 4 insertions(+), 11 deletions(-) > >--- a/include/linux/coda_psdev.h~coda-remove-uapi-linux-coda_psdevh >+++ a/include/linux/coda_psdev.h >@@ -3,8 +3,11 @@ > #define __CODA_PSDEV_H > > #include <linux/backing-dev.h> >+#include <linux/magic.h> > #include <linux/mutex.h> >-#include <uapi/linux/coda_psdev.h> >+ >+#define CODA_PSDEV_MAJOR 67 >+#define MAX_CODADEVS 5 /* how many do we allow */ > > struct kstatfs; > >--- a/include/uapi/linux/coda_psdev.h >+++ /dev/null >@@ -1,10 +0,0 @@ >-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ >-#ifndef _UAPI__CODA_PSDEV_H >-#define _UAPI__CODA_PSDEV_H >- >-#include <linux/magic.h> >- >-#define CODA_PSDEV_MAJOR 67 >-#define MAX_CODADEVS 5 /* how many do we allow */ >- >-#endif /* _UAPI__CODA_PSDEV_H */ >_