In message <20080430101704.9cbd6384.akpm@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton writes: [...[ > Can we avoid having to think? > > void fsstack_copy_inode_size(struct inode *dst, const struct inode *src) > { > blkcnt_t i_blocks; > loff_t i_size; > > i_size = i_size_read(src); > spin_lock_32bit(&src->i_lock); > i_blocks = src->i_blocks; > spin_unlock_32bit(&src->i_lock); > > i_size_write(dst, i_size); > spin_lock_32bit(&dst->i_lock) > dst->i_blocks = i_blocks; > spin_unlock_32bit(&dst->i_lock) > } I can't find spin_[um]lock_32bit anywhere (checkd latest mmotm and linus's tree). I therefore assume this was just your way of saying I should: #if BITS_PER_LONG == 32 spin_unlock(&dst->i_lock); #endif Erez. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html