In message <20080430101704.9cbd6384.akpm@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton writes:
> On Mon, 21 Apr 2008 02:50:42 -0400
> Erez Zadok <ezk@xxxxxxxxxxxxx> wrote:
[...]
> Can we avoid having to think?
>
> void fsstack_copy_inode_size(struct inode *dst, const struct inode *src)
> {
> blkcnt_t i_blocks;
> loff_t i_size;
>
> i_size = i_size_read(src);
> spin_lock_32bit(&src->i_lock);
> i_blocks = src->i_blocks;
> spin_unlock_32bit(&src->i_lock);
>
> i_size_write(dst, i_size);
> spin_lock_32bit(&dst->i_lock)
> dst->i_blocks = i_blocks;
> spin_unlock_32bit(&dst->i_lock)
> }
Thanks. I can't say that I'm an expert in these SMP issues. But I'll run
your rewritten function through my 32 and 64-bit SMP and non-SMP systems,
and see how it behaves.
Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
