On Sat, Apr 27, 2019 at 11:09 PM Murphy Zhou <jencce.kernel@xxxxxxxxx> wrote: > > On Thu, Apr 25, 2019 at 12:39 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > Overlayfs "fake" path is used for stacked file operations on > > underlying files. Operations on files with "fake" path must not > > generate fsnotify events with path data, because those events have > > already been generated at overlayfs layer and because the reported > > event->fd for fanotify marks on underlying inode/filesystem will > > have the wrong path (the overlayfs path). > > > > Link: https://lore.kernel.org/linux-fsdevel/20190423065024.12695-1-jencce.kernel@xxxxxxxxx/ > > Reported-by: Murphy Zhou <jencce.kernel@xxxxxxxxx> > > Fixes: d1d04ef8572b ("ovl: stack file ops") > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > --- > > > > Miklos, > > > > V1 was addressed to Jan and was trying to teach fsnotify about fake path. > > V2 leaves fsnotify subsystem alone and just sets the FMODE_NONOTIFY > > flag on realfile. All the rest of the complications with mark mounts > > are irrelevant. > > > > Same extended fanotify06 that was used to verify V1 also verified V2. > > Thanks for fixing this! > > My overlayfs tests on this patch looks good. Thanks, applied. Miklos
