> +static int gfs2_iomap_page_prepare(struct inode *inode, loff_t pos, > + unsigned len, struct iomap *iomap) > +{ > + return 0; > +} Now that we check for each callback there is no need to add a dummy one in this patch. But given that that won't change the end result: Reviewed-by: Christoph Hellwig <hch@xxxxxx>