DFS patch series

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I merged the first patch in your remaining cifs dfs series patch
0001-Adds-to-dns_resolver-checking-if-the-server-name-is.patch into
the cifs tree, but isn't this section of the 2nd patch of three ie
0002-fixed-compatibility-issue-with-samba-a-refferal-req.patch
incorrect? It is converting the slashes in the whole path (not in the
UNC prefix) - so escape sequences in real posix directory and file
names will be converted to separators.  This seems wrong.  We should
be converting just the treename part here.

@@ -243,6 +240,12 @@ static char
*build_full_dfs_path_from_dentry(struct dentry *dentry)
                strncpy(tmp_path, cifs_sb->tcon->treeName, l_max_len);
                strcat(tmp_path, search_path);
                tmp_path[l_max_len-1] = 0;
+               if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_POSIX_PATHS)
+                       for (i = 0; i < l_max_len; i++) {
+                               if (tmp_path[i] == '\\')
+                                       tmp_path[i] = '/';
+                       }
+
                full_path = tmp_path;
                kfree(search_path);
        } else {


-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux