Hello, Lines 1264 and 1265 need to switch. julia ---------- Forwarded message ---------- Date: Sun, 21 Apr 2019 01:22:18 +0800 From: kbuild test robot <lkp@xxxxxxxxx> To: kbuild@xxxxxx Cc: Julia Lawall <julia.lawall@xxxxxxx> Subject: [vfs:work.nfs-mount 23/23] fs/nfs/fs_context.c:1267:13-16: ERROR: reference preceded by free on line 1265 CC: kbuild-all@xxxxxx CC: linux-fsdevel@xxxxxxxxxxxxxxx TO: David Howells <dhowells@xxxxxxxxxx> CC: Al Viro <viro@xxxxxxxxxxxxxxxxxx> tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.nfs-mount head: 41de4236a25d8424df01720efebe54dcb34bc844 commit: 41de4236a25d8424df01720efebe54dcb34bc844 [23/23] NFS: Add fs_context support. :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> >> fs/nfs/fs_context.c:1267:13-16: ERROR: reference preceded by free on line 1265 # https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/commit/?id=41de4236a25d8424df01720efebe54dcb34bc844 git remote add vfs https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git git remote update vfs git checkout 41de4236a25d8424df01720efebe54dcb34bc844 vim +1267 fs/nfs/fs_context.c 41de4236 David Howells 2018-11-15 1247 41de4236 David Howells 2018-11-15 1248 /* 41de4236 David Howells 2018-11-15 1249 * Handle duplication of a configuration. The caller copied *src into *sc, but 41de4236 David Howells 2018-11-15 1250 * it can't deal with resource pointers in the filesystem context, so we have 41de4236 David Howells 2018-11-15 1251 * to do that. We need to clear pointers, copy data or get extra refs as 41de4236 David Howells 2018-11-15 1252 * appropriate. 41de4236 David Howells 2018-11-15 1253 */ 41de4236 David Howells 2018-11-15 1254 static int nfs_fs_context_dup(struct fs_context *fc, struct fs_context *src_fc) 41de4236 David Howells 2018-11-15 1255 { 41de4236 David Howells 2018-11-15 1256 struct nfs_fs_context *src = nfs_fc2context(src_fc), *ctx; 41de4236 David Howells 2018-11-15 1257 41de4236 David Howells 2018-11-15 1258 ctx = kmemdup(src, sizeof(struct nfs_fs_context), GFP_KERNEL); 41de4236 David Howells 2018-11-15 1259 if (!ctx) 41de4236 David Howells 2018-11-15 1260 return -ENOMEM; 41de4236 David Howells 2018-11-15 1261 41de4236 David Howells 2018-11-15 1262 ctx->mntfh = nfs_alloc_fhandle(); 41de4236 David Howells 2018-11-15 1263 if (!ctx->mntfh) { 41de4236 David Howells 2018-11-15 1264 return -ENOMEM; 41de4236 David Howells 2018-11-15 @1265 kfree(ctx); 41de4236 David Howells 2018-11-15 1266 } 41de4236 David Howells 2018-11-15 @1267 nfs_copy_fh(ctx->mntfh, src->mntfh); 41de4236 David Howells 2018-11-15 1268 41de4236 David Howells 2018-11-15 1269 __module_get(ctx->nfs_mod->owner); 41de4236 David Howells 2018-11-15 1270 ctx->client_address = NULL; 41de4236 David Howells 2018-11-15 1271 ctx->mount_server.hostname = NULL; 41de4236 David Howells 2018-11-15 1272 ctx->nfs_server.export_path = NULL; 41de4236 David Howells 2018-11-15 1273 ctx->nfs_server.hostname = NULL; 41de4236 David Howells 2018-11-15 1274 ctx->fscache_uniq = NULL; 41de4236 David Howells 2018-11-15 1275 fc->fs_private = ctx; 41de4236 David Howells 2018-11-15 1276 return 0; 6a5fea56 David Howells 2018-11-15 1277 } 41de4236 David Howells 2018-11-15 1278 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation