On Sat, Apr 13, 2019 at 10:02:42PM +0100, Al Viro wrote: > What's the point of using fget_raw(), if you do > _not_ accept O_PATH descriptors? That should be fget()... I think you're talking about commit e03e7ee34fdd ("perf/bpf: Convert perf_event_array to use struct file") I don't really remember why we went with this instead of fget(). There was a bunch of back and forth back then with Peter. Now it looks like that it can be fget just fine. I think cgroup_get_from_fd() should do the same too?