Re: [PATCH V3] block: don't use for-inside-for in bio_for_each_segment_all

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/11/19 7:26 AM, David Sterba wrote:
> On Mon, Apr 08, 2019 at 08:19:59AM -0600, Jens Axboe wrote:
>> On 4/8/19 5:02 AM, Ming Lei wrote:
>>> Commit 6dc4f100c175 ("block: allow bio_for_each_segment_all() to
>>> iterate over multi-page bvec") changes bio_for_each_segment_all()
>>> to use for-inside-for.
>>>
>>> This way breaks all bio_for_each_segment_all() call with error out
>>> branch via 'break', since now 'break' can only break from the inner
>>> loop.
>>>
>>> Fixes this issue by implementing bio_for_each_segment_all() via
>>> single 'for' loop, and now the logic is very similar with normal
>>> bvec iterator.
>>
>> Applied, thanks Ming.
> 
> What's the merge target please? This affects btrfs testing so I wonder
> if we should start adding workarounds or just wait for the next rc.
> Thanks.

It's queued up in my for-linus, so it's for this series. It'll go
upstream tomorrow.


-- 
Jens Axboe




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux