On Wed, Apr 10, 2019 at 3:30 PM Matteo Croce <mcroce@xxxxxxxxxx> wrote: > > On Wed, Apr 10, 2019 at 11:51 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > > On Wed, Apr 10, 2019 at 12:24 PM Matteo Croce <mcroce@xxxxxxxxxx> wrote: > > > > > > On Wed, Apr 10, 2019 at 8:46 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > > > > > > On Mon, Apr 8, 2019 at 3:09 PM Matteo Croce <mcroce@xxxxxxxxxx> wrote: > > > > > > > > > > Use the shared variables for range check, instead of declaring a local one > > > > > in every source file. > > > > > > > > I was expecting this to be a tree-wide change for all the cases found > > > > by patch 1's "git grep". > > > > > > > > > > Hi Kees, > > > > > > I have already the whole patch ready, but I was frightened by the > > > output of get_maintainer.pl, so I decided to split the patch into > > > small pieces and send the first one. > > > > Heh, sounds fine. Normally the big tree-wide changes go via Linus just > > before cutting rc1 (or rc2). This is "only" 31 source files, though, > > so maybe akpm wants to take these instead? Andrew, how do you feel > > about that? > > > > FYI, this are the stats from my local repo, just to let you the size > of a series with all the changes in it: > > $ git --no-pager log --stat --oneline linus/master > 2 files changed, 4 insertions(+), 9 deletions(-) > 2 files changed, 7 insertions(+), 14 deletions(-) > 6 files changed, 15 insertions(+), 30 deletions(-) > 1 file changed, 16 insertions(+), 19 deletions(-) > 1 file changed, 3 insertions(+), 5 deletions(-) > 3 files changed, 15 insertions(+), 20 deletions(-) > 12 files changed, 93 insertions(+), 116 deletions(-) > 3 files changed, 98 insertions(+), 104 deletions(-) > 2 files changed, 9 insertions(+) Tiny! :) Seriously, though, I think this should be fine to take directly to Linus after patch 1 lands, or see if akpm wants to carry it directly. -- Kees Cook