On Wed, Apr 23, 2008 at 04:29:02PM -0400, David M. Richter wrote:
> fcntl_setlease() has a struct dentry* that is used only once; this patch
> removes it.
Thanks, I've applied all four.
It seems to me that generic_setlease() has a lot of special handling for
the unlock case. I wonder if it'd work out to be simpler split out as a
separate function calling helper functions for common code.
--b.
>
> Signed-off-by: David M. Richter <richterd@xxxxxxxxxxxxxx>
> ---
> fs/locks.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/locks.c b/fs/locks.c
> index 6a132cd..2e0fa66 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -1493,8 +1493,7 @@ EXPORT_SYMBOL_GPL(vfs_setlease);
> int fcntl_setlease(unsigned int fd, struct file *filp, long arg)
> {
> struct file_lock fl, *flp = &fl;
> - struct dentry *dentry = filp->f_path.dentry;
> - struct inode *inode = dentry->d_inode;
> + struct inode *inode = filp->f_path.dentry->d_inode;
> int error;
>
> locks_init_lock(&fl);
> --
> 1.5.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
