The patch looks quite clean, but there still is the fundamental issue of rejecting perfectly fine UNIX filenames in xfs_unicode_validate, as discussed in the last round a Unix filename is any valid NULL-terminated bytestream with only ".", "..", and "/" special-cased and this patch breaks this assumptions. In addition to that I think xfs_unicode.[ch] should be split into a small xfs-specific part for reading the on-disk case-folding table and implementing the actual nameops, and the generic code for case folding and compares and case-folded strings should be moved into lib/ as it's quite generic. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html