> +extern struct dentry_operations xfs_ci_dentry_operations; this one is not used nor does the variable exist. Just kill it :) > +static inline int xfs_sb_version_hasoldci(xfs_sb_t *sbp) > +{ > + return (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_4) && \ > + ((sbp)->sb_versionnum & XFS_SB_VERSION_BORGBIT); > +} Lots of superflous braces here. Should be: static inline int xfs_sb_version_hasoldci(xfs_sb_t *sbp) { return (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_4) && (sbp->sb_versionnum & XFS_SB_VERSION_BORGBIT); } (and yes, the other xfs_sb_version_ helpers need fixups like that aswell) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html