On Sun, Apr 20, 2008 at 11:57:22AM +0200, Marcin Slusarz wrote: > > > +static void set_block_shift(struct omfs_sb_info *sbi) > > > +{ > > > + unsigned int scale = sbi->s_blocksize / sbi->s_sys_blocksize; [...] > > isn't it get_bitmask_order(scale - 1)? > > I mean get_bitmask_order(scale >> 1) ;) Thank you for your comments. Hmm, yeah I think so. It could also lose the divide: scale = get_bitmask_order(sbi->s_blocksize) - get_bitmask_order(sbi->s_sys_blocksize); (or ffs/fls for that matter.) -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html