Andrew, Kees, Eric sent a fix out for proc_do_large_bitmap() last month for when using a large input buffer. After patch review a test case for the issue was built and submitted. I noticed there were a few issues with the tests, but instead of just asking Eric to address them I've taken care of them and ammended the commit where necessary. There's a few issues he reported which I also address and fix in this series. Since we *do* expect users of these scripts to also use them on older kernels, I've also addressed not breaking calling the script for them, and gives us an easy way to easily extend our tests cases for future kernels as well. Before anyone considers these for stable as minor fixes, I'd recommend we also address the discrepancy on the read side of things: modify the test script to use diff against the target file instead of using the temp file. Eric Sandeen (2): test_sysctl: add proc_do_large_bitmap() test case sysctl: Fix proc_do_large_bitmap for large input buffers Luis Chamberlain (4): test_sysctl: remove superfluous test_reqs() test_sysctl: load module before testing for it test_sysctl: ignore diff output on verify_diff_w() test_sysctl: allow graceful use on older kernels kernel/sysctl.c | 30 ++++- lib/test_sysctl.c | 18 ++- tools/testing/selftests/sysctl/sysctl.sh | 161 +++++++++++++++++++---- 3 files changed, 178 insertions(+), 31 deletions(-) -- 2.18.0
